Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutil.copyfileobj(response.raw, f) doesn't work for me #16

Closed
mentaal opened this issue Mar 16, 2014 · 2 comments
Closed

shutil.copyfileobj(response.raw, f) doesn't work for me #16

mentaal opened this issue Mar 16, 2014 · 2 comments

Comments

@mentaal
Copy link

mentaal commented Mar 16, 2014

Hi there,
Can I just start by saying that this is a very nice little module!
I am trying to download a file from a Sharepoint site and when I do so I end up with an empty file.
I looked in the code and tried using your original (i'm guessing) line: f.write(response.content) @line 126 of client.py which works just fine for me instead of the shutil.copyfileobj method call.
I can't figure out what is wrong, your code looks fine. Could it be something up on my end?
I am in business anyway but I just thought I would point this out.
Thanks!

@amnong
Copy link
Owner

amnong commented Apr 2, 2014

Hey Mentaal,
Glad you're enjoying my library. Unfortunately I've been neglecting it for the past year and a half, sorry for that.

This really sounds like #9 and #11. You should beware - if this is indeed the case, you may have a serious memory problem when downloading large files.

I'm going to pull a pending merge request really soon, which should fix this problem.

Thanks,
Amnon

@amnong
Copy link
Owner

amnong commented May 30, 2014

Closing for lack of response. Please reopen if you still encounter the problem.

@amnong amnong closed this as completed May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants