feature_request(encoding): force UTF-8 for Windows users

[Kristinita]

1. Summary

In my opinion, UTF-8 should be the default encoding for Windows users. If developers of delegator.py don't want to do this, it would be nice to have an option for UTF-8.

2. Argumentation

I don't understand, why needs these lines for Windows users.

if sys.platform == 'win32':
    default_encoding = locale.getdefaultlocale()[1]
    if default_encoding is not None:
        encoding = default_encoding

More about locale.getdefaultlocale(). I have English Windows and Russian language for non-unicode programs. Python interpreter output:

>>> import locale
>>> locale.getdefaultlocale()
('en_US', 'cp1251')

I change my language for non-Unicode programs to English (United States) as recommend in this answer:

I restart Windows → I open Python Interpreter again:

>>> import locale
>>> locale.getdefaultlocale()
('en_US', 'cp1252')

Not UTF-8 again. The example shows that locale.getdefaultlocale() can't set UTF-8 for Windows.

3. Example

• SashaDelegator.py (in UTF-8):

import delegator

print(delegator.run('echo Саша Богиня!').out)

I run in console python SashaDelegator.py

4. Expected behavior

Саша Богиня!

5. Actual behavior

???? ??????!

This hack also doesn't help.

import _locale
import delegator

_locale._getdefaultlocale = (lambda *args: ['en_US', 'utf8'])

print(delegator.run('echo Саша Богиня!').out)

I get the same output.

And if I use hacks, I have problems with code quality tools.

6. Environment

• Windows 10 Enterprise LTSB 64-bit EN
• Python 3.7.0
• delegator.py 0.1.0
• PYTHONIOENCODING utf-8

Thanks.

[Kristinita]

@nateprewitt , @kennethreitz, any ideas, how to fix it?

Thanks.

[danieldjewell]

For what it's worth, this sounds like a Python issue perhaps? The locale module is part of Python itself, of course (https://docs.python.org/3/library/locale.html) ...

Also, be aware that a lot of Windows -things- default to UTF-16... Also, check out Microsoft Terminal for a much improved CLI experience (https://github.com/microsoft/terminal)