Skip to content

Commit

Permalink
update github workflow and fix build app issue
Browse files Browse the repository at this point in the history
  • Loading branch information
amitamrutiya committed Jan 25, 2024
1 parent 762d2be commit 3133d88
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 17 deletions.
13 changes: 0 additions & 13 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,7 @@ module.exports = {
'react',
],
rules: {
// 'no-console': 'off', // Warns about console.log statements
// 'react/prop-types': 'off', // Turns off prop-types rule for React
'comma-dangle': ['error', 'always-multiline'], // Enforces trailing commas for multiline statements
// 'prefer-const': 'error', // Requires that developers use const for variables that are never reassigned after declared
// 'react/jsx-uses-react': 'error', // Prevents React to be incorrectly marked as unused
// 'react/jsx-uses-vars': 'error', // Prevents variables used in JSX to be incorrectly marked as unused
// 'react-hooks/rules-of-hooks': 'off', // Checks rules of Hooks
// 'react-hooks/exhaustive-deps': 'off', // Checks effect dependencies
// 'no-mixed-operators': 'off', // Allows mixed operators
// 'no-void': 'off', // Allows void operator
// 'no-return-assign': 'off', // Allows return statements to be used in the value position of assignments
// 'no-unused-expressions': 'off', // Allows unused expressions
// 'no-sequences': 'off', // Allows comma operator
// 'no-var': 'off', // Requires that var is not used
'react/jsx-filename-extension': ['warn', { extensions: ['.js', '.jsx'] }], // Enforces .jsx extension for JSX files
'react/react-in-jsx-scope': 'off', // Prevents React to be incorrectly marked as unused
},
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/workflow_backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ jobs:
- name: Install Dependencies
run: npm install --prefix backend

- name: Run ESLint
run: npx eslint . --ext .js

- name: Run Tests
run: npm test --prefix backend

8 changes: 4 additions & 4 deletions .github/workflows/workflow_frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ jobs:
- name: Install Dependencies
run: npm install --prefix frontend

# - name: Build
# run: npm run build --prefix frontend
- name: Run ESLint
run: npx eslint . --ext .js,.jsx

# - name: Test
# run: npm test --prefix frontend
- name: Build
run: npm run build

0 comments on commit 3133d88

Please sign in to comment.