Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"no foreign-born population" message in 1850 and 1860 #5

Open
almccon opened this issue Feb 11, 2016 · 4 comments
Open

"no foreign-born population" message in 1850 and 1860 #5

almccon opened this issue Feb 11, 2016 · 4 comments
Assignees

Comments

@almccon
Copy link
Member

almccon commented Feb 11, 2016

In 1850 and 1860 we don't have county-level data, so we can't change the display of the map when you select a country. However, we should leave the bar chart in place, instead of loading the "This country had no foreign-born population in the selected year" message.

foreignborn_bug

@ebrelsford
Copy link
Collaborator

@almccon I'm not sure how you'd like to leave the bar chart in place if there is no data. Would this look like a list of countries with 0s next to them? That feels slightly inconsistent to me with existing behavior since the countries list shrinks as there are fewer to show:

foreignborn-barchart

@almccon
Copy link
Member Author

almccon commented Apr 1, 2016

When a county is selected in 1850 or 1860 there should be no bar chart, so you're seeing the correct behavior. But when a country is selected, the bar chart erroneously disappears.

@almccon
Copy link
Member Author

almccon commented Apr 1, 2016

The similarity between the words county and country has been driving us crazy throughout this project!

@ebrelsford
Copy link
Collaborator

Ahhh got it, thanks @almccon!

@emilyhobson emilyhobson assigned sconnelley and unassigned ebrelsford Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants