Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gilcrease Classifications file is outdated #3

Open
VladimirAlexiev opened this issue Feb 24, 2017 · 5 comments
Open

Gilcrease Classifications file is outdated #3

VladimirAlexiev opened this issue Feb 24, 2017 · 5 comments

Comments

@VladimirAlexiev
Copy link
Member

VladimirAlexiev commented Feb 24, 2017

Gilcrease AAC Classification Mapping (8.2.16).xlsx maps "Anth- Ceramic, Plaster" to "materials by composition". This is definitely wrong:

  • it's too generic
  • it's a facet, not a concept to be used for indexing.

I can't find on google what is this special plaster. But explore the plaster hirerarchy and pick something.

  • Perhaps simply aac:300014922 "plaster"
  • definitely not the facet "plaster by composition or origin"
@kateblanch
Copy link
Collaborator

@Diana-Folsom

@Diana-Folsom
Copy link

It sounds like the old, incorrect version of the data is being used. These old, whacky categories should have been deleted in the newer version of data.

@caknoblock
Copy link

caknoblock commented Mar 5, 2017 via email

@Diana-Folsom
Copy link

Craig,
This is the old file - we updated our data and posted a new file in August, 2016.

Kate,
Is there a different place or way in which we should post the data? I believe we used the same format as the original posting.

Although we not need to make some other Classification changes, I hope that the August data contribution can be the one used now, and we will contribute the changes we are making based on Vladimir's helpful observations.

Thanks!
Diana

@kateblanch
Copy link
Collaborator

Hi @Diana-Folsom! Thanks for your help investigating.
I see the file you posted in August - Gilcrease AAC Classification Mapping (8.2.16).xlsx.
Is there a newer one that you posted after August 2nd?

I'm comparing the data Craig's using - https://github.com/american-art/AAT-Term-Mappings/tree/master/karma/cleaned_data/GM Classification.xlsx and this file Gilcrease AAC Classification Mapping (8.2.16).xlsx and they look the same.

Did the classifications get cleaned up at the object level, perhaps?
This file https://github.com/american-art/GM/blob/master/Classifications/Classifications.csv seems to much fewer classifications.

@VladimirAlexiev VladimirAlexiev changed the title Gilcrease Anth- Ceramic, Plaster Gilcrease Classifications file is outdated Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants