-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gilcrease Classifications file is outdated #3
Comments
It sounds like the old, incorrect version of the data is being used. These old, whacky categories should have been deleted in the newer version of data. |
You can review the version of the data that we are using here: https://github.com/american-art/AAT-Term-Mappings/tree/master/karma/cleaned_data <https://github.com/american-art/AAT-Term-Mappings/tree/master/karma/cleaned_data> and this file can be updated, but it needs to be in this format.
… On Mar 4, 2017, at 4:22 PM, Diana-Folsom ***@***.***> wrote:
It sounds like the old, incorrect version of the data is being used. These old, whacky categories should have been deleted in the newer version of data.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABB-qUvPMFQ9_lPfDNBo4_jIY6WoPQvEks5rigA_gaJpZM4MLKkL>.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/american-art/AAT-Term-Mappings","title":"american-art/AAT-Term-Mappings","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in ***@***.*** in #3: It sounds like the old, incorrect version of the data is being used. These old, whacky categories should have been deleted in the newer version of data. "}],"action":{"name":"View Issue","url":"#3 (comment)! 148"}}}
|
Craig, Kate, Although we not need to make some other Classification changes, I hope that the August data contribution can be the one used now, and we will contribute the changes we are making based on Vladimir's helpful observations. Thanks! |
Hi @Diana-Folsom! Thanks for your help investigating. I'm comparing the data Craig's using - https://github.com/american-art/AAT-Term-Mappings/tree/master/karma/cleaned_data/GM Classification.xlsx and this file Gilcrease AAC Classification Mapping (8.2.16).xlsx and they look the same. Did the classifications get cleaned up at the object level, perhaps? |
Gilcrease AAC Classification Mapping (8.2.16).xlsx
maps "Anth- Ceramic, Plaster" to "materials by composition". This is definitely wrong:I can't find on google what is this special plaster. But explore the plaster hirerarchy and pick something.
The text was updated successfully, but these errors were encountered: