-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor preview parsing #79
Comments
I was checking this issue and I noticed this line: https://github.com/amarofashion/react-credit-cards/blob/master/src/index.js#L74 Given the logic below where the try to update the I did some tests locally with 16, 19 digit cards as well the Diners type mentioned in issue #70 and it appears to solve our issues. @gilbarbara what do you think? Any edge cases that you can think of? |
Actually the task is to handle formatting with these cards and not exactly detect the maxLength. Is that it? |
This is what I noticed locally while testing with the number provided in issue #70 (preview mode - Diners card w/ 14 digits): That's why I thought we would need to update |
It should work with Amex, Diners, 16, and 19 characters.
The text was updated successfully, but these errors were encountered: