Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the url is written as a parameter, accessing /en?sku=123 causes the web page to crash #502

Closed
lynn1286 opened this issue Sep 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@lynn1286
Copy link

lynn1286 commented Sep 8, 2023

Description

When I access /en?sku=123 on the official case, it will always redirect and eventually crash the browser. Please note that there is no problem accessing /?sku=123.

iShot_2023-09-08_19.44.11.mp4

Mandatory reproduction URL (CodeSandbox or GitHub repository)

https://codesandbox.io/p/sandbox/github/amannn/next-intl/tree/main/examples/example-next-13

Reproduction description

Steps to reproduce:

  1. Open reproduction
  2. Click on …
  3. See error: …

Expected behaviour

I hope to be able to access normally

@lynn1286 lynn1286 added bug Something isn't working unconfirmed Needs triage. labels Sep 8, 2023
@amannn
Copy link
Owner

amannn commented Sep 11, 2023

Thanks for the bug report, I can reproduce this too.

We have quite an extensive suite of tests for the middleware here, where this can likely be isolated to a failing test case: https://github.com/amannn/next-intl/blob/main/packages/next-intl/test/middleware/middleware.test.tsx

Would you be interested in contributing this fix? Just let me know, otherwise I'll try to look into this.

@amannn amannn removed the unconfirmed Needs triage. label Sep 11, 2023
@amannn
Copy link
Owner

amannn commented Nov 14, 2023

This was fixed as part of #149 (released in 3.0).

@amannn amannn closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants