Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Design history animation" rotates about wrong axis #7

Open
positron96 opened this issue Nov 16, 2023 · 5 comments
Open

"Design history animation" rotates about wrong axis #7

positron96 opened this issue Nov 16, 2023 · 5 comments

Comments

@positron96
Copy link

Hello and thank you for an excellent plugin! I am trying out Design history animation add-in, and it seems to rotate the camera in vertical plane, not horizontal. Maybe the axes in my project are not default (my vertical axis is Z and frontal plane is XZ)

@FutureJames
Copy link

FutureJames commented Apr 28, 2024

Similar issue. I see that in the docs it references "y-axis" being the default vertical for Fusion360, but I have only ever seen it set to "z-axis". Historically, many 3d editors use Y as vertical (Maya, 3DSMax, Unity), while others use Z as vertical (Unreal, Blender, Fusion360). Given that there are several great looking animations in the README for this repo, I assume there is something I am missing. That being said, I have updated the script to just allow the user to select X, Y, or Z for the axis of rotation. I will submit a PR if that is welcomed. Either way, great script functionality. thanks for sharing your work!

(edit)
Never mind. Looks like someone already submitted a PR :)

@amandaghassaei
Copy link
Owner

thanks for bringing this to my attention, it looks like the current pr is for the spin animation only. Would you mind submitting a pr for the design history animation? happy to merge it in, just don't have the time to write it myself!

@amandaghassaei
Copy link
Owner

I've just merged the other pr btw.

@FutureJames
Copy link

Cool, I will give things a once over and do a little more testing and submit a PR. I am also working on a refactor that takes a lot of your ideas and consolidates them into a single tool, while updating to fix a few bugs and deprecated APIs. I kind of just made it to suit my own uses cases, but I'd be happy to submit it back here as well if you'd like. Either way, I have you credited in the docs and comments.

@amandaghassaei
Copy link
Owner

sounds good, happy to take a look. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants