Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What does extended_dump actually do? #265

Open
airlaser opened this issue Sep 19, 2019 · 2 comments · May be fixed by #266
Open

What does extended_dump actually do? #265

airlaser opened this issue Sep 19, 2019 · 2 comments · May be fixed by #266
Labels
question

Comments

@airlaser
Copy link

I'm diffing output from -D with and without -e and seeing no difference.

When I search the code (latest version) I see extended_dump get set by args then never used.

Am I blind or is this just not yet implemented?
@althonos
Copy link
Owner

Originally, iterating over the medias on a profile was enough to extract some metadata, but not all of it relevant to a specific post (things like top comments per post, etc. needed to be extracted on a per-post basis). However, since the implementation of the scraper changed a lot (I switched from HTML scraping to GraphQL query hijacking) so it's possible that 1. I never implemented that back or 2. it is not needed / not possible to do anymore.

@airlaser
Copy link
Author

It appears to no longer be necessary.

I will get a PR up shortly to remove it.

@airlaser airlaser linked a pull request Sep 20, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated extended_dump option airlaser/InstaLooter
2 participants
@althonos @airlaser