Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: data_get() still uses v1 #639

Open
2 tasks done
Enigma56 opened this issue Jul 17, 2022 · 0 comments
Open
2 tasks done

[Bug]: data_get() still uses v1 #639

Enigma56 opened this issue Jul 17, 2022 · 0 comments

Comments

@Enigma56
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Throws an HTTP 404 Error saying that there is no endpoint "https://data.alpaca.markets/v1/stocks/AAPL/trades"

Expected Behavior

Return the trade with whatever query results are given.

SDK Version I encountered this issue in

alpaca-trade-api: version 2.3.0

Steps To Reproduce

Run any .data_get() call without specifying the version as v2

Filled out the Steps to Reproduce section?

  • I have entered valid steps to reproduce my issue or have attached a minimally reproducible case in code that shows my issue happening; and understand that without this my issue will be flagged as invalid and closed after 30 days.

Anything else?

Simply change the code inside of the SDK to default data_get() to version 2 instead of version 1

OR

change the default to v1beta1. No where on the api documentation for market data does it still use v1 as a valid version.

OR write a more clear error that gets thrown inside of the SDK to tell people to change api_version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant