New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bc2allvm: TOCTTOU problems in file exists checks #5

Open

dtzWill opened this issue Feb 14, 2018 · 0 comments

Labels

bug

Member

dtzWill commented Feb 14, 2018

bc2allvm checks if the output file exists separately from attempting to open the file for writing.

The check:

https://gitlab-beta.engr.illinois.edu/llvm/allvm/blob/78bd77c5012e5ddf616b975cc31580effba2450d/tools/bc2allvm/bc2allvm.cpp#L69

A file could be created between the two invocations and resulting in wrong behavior and/or wrong error messages.

This probably blocks on revamping how we emit Allexe files.

dtzWill added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment