Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Extend Provider Implementations #320

Closed
refcell opened this issue Dec 1, 2024 · 1 comment
Closed

[Feature] Extend Provider Implementations #320

refcell opened this issue Dec 1, 2024 · 1 comment
Labels
A-provider Area: provider crate C-feat Category: New feature or request good-first-issue Issues that are easy to pick up for new contributors

Comments

@refcell
Copy link
Collaborator

refcell commented Dec 1, 2024

Component

provider

Describe the feature you would like

The alloy-provider crate has reqwest-backed implementations of the Provider trait, exposing provider implementations.

op-alloy-provider only provides an extension for the provider, but doesn't have implementations for traits in op-alloy.

This issue is to implement the BatchValidationProvider from the op-alloy-protocol crate in op-alloy-provider using the ReqwestProvider from alloy-provider. This can be hidden behind a feature flag if needed.

Exposing an implementation of the BatchValidationProvider using the ReqwestProvider allows downstream applications to easily plug in a ReqwestProvider for batch validation.

Additional context

No response
@refcell refcell changed the title [Feature] Build out op-alloy-provider [Feature] Extend Provider Implementations Dec 1, 2024
@refcell refcell added C-feat Category: New feature or request good-first-issue Issues that are easy to pick up for new contributors A-provider Area: provider crate labels Dec 1, 2024
@refcell refcell moved this to Todo in Project Tracking Jan 7, 2025
@emhane
Copy link
Collaborator

emhane commented Jan 8, 2025

closing in favour of op-rs/maili#18

@emhane emhane closed this as completed Jan 8, 2025
@github-project-automation github-project-automation bot moved this from Backlog to In Review in Project Tracking Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-provider Area: provider crate C-feat Category: New feature or request good-first-issue Issues that are easy to pick up for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@refcell @emhane