Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] More well-considered Wallet behavior #638

Open
prestwich opened this issue Apr 26, 2024 · 1 comment
Open

[Feature] More well-considered Wallet behavior #638

prestwich opened this issue Apr 26, 2024 · 1 comment
Labels
c-network Pertaining to the network crate enhancement New feature or request help wanted Extra attention is needed

Comments

@prestwich
Copy link
Member

Component

signers

Describe the feature you would like

We currently only handle individual signers, each of which has a single address. This doesn't deal well with bip32 xprivs and related signers like ledger and trezor.

EthereumSigner and the NetworkSigner trait need to be updated to allow derivation path enrollment or something else. I don't have a good design here yet but it's stewing

Additional context

No response
@prestwich prestwich added enhancement New feature or request help wanted Extra attention is needed labels Apr 26, 2024
@prestwich prestwich mentioned this issue Jun 3, 2024
Closed
@DaniPopes DaniPopes added this to the 0.1-rc.0 milestone Jun 5, 2024
@DaniPopes DaniPopes removed the 0.1-rc.0 label Jun 5, 2024
@gakonst gakonst removed this from the 0.1-rc.0 milestone Jun 5, 2024
@yash-atreya yash-atreya mentioned this issue Feb 20, 2025
Closed
@yash-atreya yash-atreya added c-network Pertaining to the network crate discuss needs discussion labels Feb 20, 2025
@jenpaff jenpaff removed the discuss needs discussion label Feb 28, 2025
@nadtech-hub
Copy link
Contributor

✋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-network Pertaining to the network crate enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jenpaff @prestwich @gakonst @nadtech-hub @yash-atreya @DaniPopes