Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make TxEnvelope generic over Eip4844 variant #2163

Open
klkvr opened this issue Mar 7, 2025 · 1 comment
Open

[Feature] Make TxEnvelope generic over Eip4844 variant #2163

klkvr opened this issue Mar 7, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@klkvr
Copy link
Member

klkvr commented Mar 7, 2025

Component

consensus, eips, genesis

Describe the feature you would like

We need to do the same change as #2162 for TxEnvelope.

The steps are:

  1. Introduce EthereumTxEnvelope<Eip4844> type and type alias TxEnvelope = EthereumTxEnvelope<TxEip4844Variant>
  2. Change all TxEnvelope impls to generic impls on EthereumTxEnvelope instead
  3. Replace PooledTransaction with type alias PooledTransaction = TxEnvelope<TxEip4844WithSidecar>
    pub enum PooledTransaction {
    /// An untagged [`TxLegacy`].
    Legacy(Signed<TxLegacy>),
    /// A [`TxEip2930`] tagged with type 1.
    Eip2930(Signed<TxEip2930>),
    /// A [`TxEip1559`] tagged with type 2.
    Eip1559(Signed<TxEip1559>),
    /// A EIP-4844 transaction, which includes the transaction, blob data, commitments, and proofs.
    Eip4844(Signed<TxEip4844WithSidecar>),
    /// A [`TxEip7702`] tagged with type 4.
    Eip7702(Signed<TxEip7702>),
    }

Additional context

No response

@klkvr klkvr added the enhancement New feature or request label Mar 7, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Mar 7, 2025
@klkvr klkvr added the good first issue Good for newcomers label Mar 7, 2025
@Rimeeeeee
Copy link

May I look on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

2 participants