-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Keep Anvil in Provider have same types as the rest of the project #1876
[Feature] Keep Anvil in Provider have same types as the rest of the project #1876
Conversation
Hi @programskillforverification thanks for your PR This change would also require an update in Foundry (https://github.com/foundry-rs/foundry/tree/master/crates/anvil) as seen in the CI errors, is this something you would be interested in adding? cc @grandizzy I think this change is reasonable to be added pre- |
It looks like that the error is due to type change of |
The error occurs because Alloy uses the alloy/crates/node-bindings/src/nodes/anvil.rs Line 258 in ae64f26
|
OK...Update |
No further changes should be necessary here, the update of the types should happen in https://github.com/foundry-rs/foundry/tree/master/crates/anvil (in Foundry) |
I see. I will open new PR in Foundry. |
This doesn't and shouldn't require an anvil update: we don't want to change the serialization, just the API of the provider. Please add the corresponding Edit: I've done it myself so we can include this in the next release. |
Motivation
close #1751