Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration code deprecated tagging from ethers > alloy #1294

Open
joshstevens19 opened this issue Sep 16, 2024 · 3 comments
Open

Migration code deprecated tagging from ethers > alloy #1294

joshstevens19 opened this issue Sep 16, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@joshstevens19
Copy link

joshstevens19 commented Sep 16, 2024

Component

meta-crate, contract, consensus, eips, genesis, network, json-rpc, node-bindings, provider, pubsub, rpc, serde, transports

Describe the feature you would like

I have a few projects in rust which use ethers-rs and also have started a few more which I started with alloy-rs I want to share a few takeaways in the migration processes:

  1. Starting a new project using alloy is excellent and easy; it is my go-to, and you guys have made an incredible library.
  2. I have one project called rindexer, in which I spent 3-4 hours trying to migrate to Alloy from Ethers, but some methods i just struggled to find the way you do it in Alloy; this made me think that larger existing projects which use more low-level Ethers will struggle to migrate without a significant investment in time. Most of the time, it was purely trying to find it, and in turn, as I don't have another 3-4 hours to spend on this migration, I have stopped for now and stayed with Ethers which I would rather not do.
  3. I have another project, which I started with Ethers and again struggled with the same issues above. Still, as it was less dependent on Ethers for a bunch of stuff, it was not as hard (still took 2-3 hours+), but I kept seeing myself jumping between Github Alloy and Github Ethers trying to find it—it was not straight forward and painful to do.

I know you have the docs https://alloy.rs/migrating-from-ethers/reference.html, but it touches only on the high-level bits if you want people to migrate away from Ethers on the existing large codebase fully, I suggest throughout the entire ethers-rs codebase attaching #[deprecated with a note pointing to where this exists now in the Alloy codebase, I know this may seem an big undertaking but as Ethers was the core rust library for a while and you want to deprecate it entirely IMHO it would be an excellent investment of time and allow people to not struggle as much in the migration, I know things change and things move but overtime you tend not to make breaking changes so even if a few deprecated get out of date on ethers it doesn't matter IMHO. I know this alone would have taken my migration time down quickly and would have allowed me to migrate 3-4x faster probably leaving me impressed once I was done. Once you do this nobody has an excuse not to migrate.

I created it here because it's directly linked to me using Alloy itself and feels like an Alloy task, even if it's done in Ethers codebase. Let the code explain to the developer how to migrate over developers searching the codebase to find where it exists now.

@joshstevens19 joshstevens19 added the enhancement New feature or request label Sep 16, 2024
@joshstevens19 joshstevens19 changed the title [Feature] migration code docs from ethers > alloy [Feature] migration code deprecated tagging from ethers > alloy Sep 16, 2024
@joshstevens19 joshstevens19 changed the title [Feature] migration code deprecated tagging from ethers > alloy Migration code deprecated tagging from ethers > alloy Sep 16, 2024
@yash-atreya yash-atreya added the documentation Improvements or additions to documentation label Feb 20, 2025
@jenpaff jenpaff added this to Alloy Feb 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Feb 28, 2025
@jenpaff jenpaff removed this from Alloy Feb 28, 2025
@jenpaff
Copy link

jenpaff commented Feb 28, 2025

we have a migration guide in alloy book https://github.com/alloy-rs/book

@jenpaff jenpaff closed this as completed Feb 28, 2025
@joshstevens19
Copy link
Author

Yeah would say politely it’s not the best @jenpaff and I for sure think it can be greatly improved

@jenpaff
Copy link

jenpaff commented Mar 2, 2025

Yeah would say politely it’s not the best @jenpaff and I for sure think it can be greatly improved

Got it ! Thanks for the feedback, let me reopen & have us take another fresh look.

@jenpaff jenpaff reopened this Mar 2, 2025
@jenpaff jenpaff added this to the v1.0 milestone Mar 2, 2025
@jenpaff jenpaff self-assigned this Mar 2, 2025
@jenpaff jenpaff added this to Alloy Mar 2, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants