Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar size parameter added incorrectly to the URL #776

Open
Piedone opened this issue Feb 7, 2024 · 0 comments
Open

Avatar size parameter added incorrectly to the URL #776

Piedone opened this issue Feb 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Piedone
Copy link

Piedone commented Feb 7, 2024

Describe the bug
The bot adds avatar images with a size parameter, but that's concatenated incorrectly with a duplicated ?, like this: https://avatars3.githubusercontent.com/u/1976647?v=4?s=100.

To Reproduce

  1. Ask the bot to add a contributor of any kind with @all-contributors please add @<username> for <contributions>.
  2. Observe that the avatar URL is added with a duplicated ?.

It looks like that this bug has existed forever, our very first contributor profiles under Orchard Core are like this too.

Expected behavior
The s parameter is added with an ampersand instead: https://avatars3.githubusercontent.com/u/1976647?v=4&s=100.

Screenshots
Not applicable.

Additional context
If it affects anything, this is the page we keep up to date: https://docs.orchardcore.net/en/latest/docs/community/contributors/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant