You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched in the issues and found nothing similar.
Description
The code style of using com.alibaba.fluss.utils.Preconditions is not consistent in Fluss. Some may use static imports (checkNotNull(...);), some may use class imports (Preconditions.checkNotNull(...);).
We have a Preconditions static importing rule in checksytle, but that is for Guava Preconditions, and Guava Preconditions was forbidden and suggested to use Fluss Precondition.
Search before asking
Description
The code style of using
com.alibaba.fluss.utils.Preconditions
is not consistent in Fluss. Some may use static imports (checkNotNull(...);
), some may use class imports (Preconditions.checkNotNull(...);
).We have a Preconditions static importing rule in checksytle, but that is for Guava Preconditions, and Guava Preconditions was forbidden and suggested to use Fluss Precondition.
fluss/tools/maven/checkstyle.xml
Line 242 in 3bf243d
We just need to update the checkstyle rule to fit Fluss Precondition, and update all the class imports in the codebase.
Willingness to contribute
The text was updated successfully, but these errors were encountered: