Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default configuration of auto partitioning #467

Open
1 of 2 tasks
wuchong opened this issue Feb 22, 2025 · 3 comments · May be fixed by #470
Open
1 of 2 tasks

Improve default configuration of auto partitioning #467

wuchong opened this issue Feb 22, 2025 · 3 comments · May be fixed by #470
Labels
component=client good first issue Good for newcomers

Comments

@wuchong
Copy link
Member

wuchong commented Feb 22, 2025

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Currently, the default configuration of auto-partitioning is not out-of-box and usually has to be configured manually. The current default configuration:

table.auto-partition.enabled = false
table.auto-partition.time-unit  // no default value
table.auto-partition.num-precreate = 4 // too many unused partitions and buckets. 
table.auto-partition.num-retention = -1 // never expire

Solution

I suggest changing the default value for the configuration in this version to make it more handy for common cases.

table.auto-partition.enabled = false // no change
table.auto-partition.time-unit = day // most cases are daily partitions
table.auto-partition.num-precreate = 2 // one partition for today, and precreate tomorrow is enough
table.auto-partition.num-retention = 7 // to be align with "table.log.ttl"

Anything else?

Some existing tests will fail after changing default values, we need to fix the tests.

Willingness to contribute

  • I'm willing to submit a PR!
@wuchong
Copy link
Member Author

wuchong commented Feb 22, 2025

What do you think about this? @luoyuxia

@gyang94 gyang94 linked a pull request Feb 23, 2025 that will close this issue
Open
@gyang94
Copy link
Contributor

gyang94 commented Feb 23, 2025

@wuchong Could you assign this task to me?
I made a quick PR #470 which just modify the default value of those configurations. I will fix related tests these days.

@luoyuxia
Copy link
Collaborator

@wuchong It sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component=client good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[common][WIP] improve default configuration of auto partitioning gyang94/fluss
3 participants
@wuchong @luoyuxia @gyang94