Skip to content

Remove deprecated hogan.js dependency also from instantsearch.js #6699

@dewey

Description

@dewey

🐛 Current behavior

Hey, there's currently a deprecated mkdirp dependency being pulled in by instantsearch.js. This was already partly removed in this PR but for some reason doesn't seem to be in the master branch.

Currently it can still be seen in https://github.com/algolia/instantsearch/blob/master/packages/instantsearch.js/package.json#L35, this is right now causing a deprecation warning as that project was deprecated 4 years ago.

npm warn deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)

There was a PR to switch to a user-maintained version a few days ago that was rejected (For good reason).

Are there any plans to remove it from instantsearch.js?

🔍 Steps to reproduce

Build a project using instantsearch.js with npm and esbuild.

Live reproduction

https://codesandbox.com

💭 Expected behavior

No warning

Package version

[email protected]

Operating system

macOS

Browser

Firefox

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageIssues to be categorized by the team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions