-
Notifications
You must be signed in to change notification settings - Fork 552
Open
Labels
triageIssues to be categorized by the teamIssues to be categorized by the team
Description
🐛 Current behavior
Hey, there's currently a deprecated mkdirp
dependency being pulled in by instantsearch.js. This was already partly removed in this PR but for some reason doesn't seem to be in the master branch.
Currently it can still be seen in https://github.com/algolia/instantsearch/blob/master/packages/instantsearch.js/package.json#L35, this is right now causing a deprecation warning as that project was deprecated 4 years ago.
npm warn deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
There was a PR to switch to a user-maintained version a few days ago that was rejected (For good reason).
Are there any plans to remove it from instantsearch.js?
🔍 Steps to reproduce
Build a project using instantsearch.js with npm and esbuild.
Live reproduction
💭 Expected behavior
No warning
Package version
Operating system
macOS
Browser
Firefox
Code of Conduct
- I agree to follow this project's Code of Conduct
lalong13
Metadata
Metadata
Assignees
Labels
triageIssues to be categorized by the teamIssues to be categorized by the team