-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading error handling #705
Comments
I'd posit that this is a significant problem. For our integration, we provide Algolia connection details only in our production environment. On non-production environments, this will generate a fatal PHP error and cause the application to crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It seems like the current implementation of the exception is misleading:
algoliasearch-client-php/src/RetryStrategy/ApiWrapper.php
Lines 151 to 196 in ffef644
To day, I got the following exception
Impossible to connect, please check your Algolia Application Id.
Turning on logging revealed that this was in fact due to a missing feature on a new infrastructure we are testing:
I would expect never to get an exception that is plain wrong. Before getting this issue, I had a problem where my index name was wrong, but it was diagnosed in the same way:
Impossible to connect, please check your Algolia Application Id.
.What I would expect would be the last error to be remembered and used in the exception message. Also, the exception type is wrong: the host was not unreachable, it was missing a feature.
The text was updated successfully, but these errors were encountered: