feat(index): add options to index.exists function #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jan 5, 2023
Currently the function `index.Exists` doesn't accept options like other functions. Options can be used to propagate the context, for example to do tracing. The goal of this commit is to add `opts` to `index.exists`
k20human
force-pushed
the
feature/exists-opts
branch
from
8be69f4
to
c147213
Compare
|
Will keep this for the next major release. |
|
@samouss should there be a v4 branch for contributing such breaking changes? |
|
@greg0ire We have no plan for such release so far. I've kept the issue with the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Currently the function
index.Existsdoesn't accept options like other functions.Options can be used to propagate the context, for example to do tracing. The goal of this commit is to add
optstoindex.existsWhat problem is this fixing?
Propagate opts to others functions call by
Existsfunction