-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge-cases where arkade chart upgrade picks the wrong tag #936
Labels
Comments
alexellis
changed the title
Edge-cases where arkade chart upgrade does the wrong thing
Edge-cases where arkade chart upgrade picks the wrong tag
Jun 16, 2023
Who feels like a challenge and can work on this within the next few days? |
@joebowbeer wdyt? |
alexellis
added
help wanted
Extra attention is needed
good first issue
Good for newcomers
labels
Jun 23, 2023
I'm offering up a small token / bounty 💎 for this - https://twitter.com/alexellisuk/status/1672245426831908864?s=20 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are two edge-cases where arkade chart upgrade picks the wrong tag for an image
Expected Behaviour
prom/prometheus:v2.44.0
andprom/prometheus:v2.45.0-rc0
should not move from a stable version to an RCmoby/buildkit:v0.11.6-rootless
andmoby/buildkit:v0.11.6
. In my YAML file I have:moby/buildkit:v0.11.6-rootless
, but the upgrade command just finds the latest and replaces it with:moby/buildkit:v0.11.6
which is wrongPossible Solution
Steps to Reproduce (for bugs)
Wrong output:
Right output:
Context
This makes means additional checking and having to undo/manually change the upgrade steps
See also: https://github.com/alexellis/arkade/blob/master/cmd/chart/upgrade.go
Any PR should have tests that show the original problem is fixed, this may require a little refactoring.
The text was updated successfully, but these errors were encountered: