Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respeciate_Generic missing grouping when re-defining species #8

Open
KateBolamEllis opened this issue Dec 6, 2024 · 0 comments
Open

Comments

@KateBolamEllis
Copy link

Hiya, I think I've found an error with Respeciate_Generic. I think the source code is missing 'by=group_vars' when recoding the organism based on the flags.

When I run the function as is, records that shouldn't be affected (i.e. not SP/UNNAMED) get a completely different species (often of a different genus) based on default = get(species_col)[1]. I think 'by=group_vars' needs adding to ensure these are not incorrectly changed.

Thanks for a great package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant