-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic on graceful shutdown #24
Comments
Share the code that you have, there are tests covering this area, it should work. |
Hello, thanks for answering so quickly. In my PR the test reproduces the panic. I'm new to all this git stuff, sorry, I should have committed the test separately from the fix. |
Hello, hope u are doing well Is there eventually any update about this ? I am getting each time i do a ctrl+c a panic when calling shutdown like above stated Regards |
Yes, there's going to be a fix, I was working on it, but right now I don't have time to continue it. |
Hello, when using the
Shutdown
method, I get a panic:This is because the
removeClient
channel is closed before all HTTP handlers got closed.I am a beginner, but to me it looks like we should never close
removeClient
.But it will allow a goroutine leak, since goroutines trying to send on this channel will remain blocked.
I'll try to post a PR.
The text was updated successfully, but these errors were encountered: