some fix

Author: aynsix

api/config/packages/messenger.yaml

@@ -26,4 +26,4 @@ when@test:
     framework:
         messenger:
             transports:
-                async: 'in-memory://'
+                async: 'sync://'

api/src/Consumer/Handler/BuildArchive.php

@@ -6,7 +6,7 @@
 
 class BuildArchive
 {
-    public function __construct(private string $id = '')
+    public function __construct(private string $id)
     {
     }
 

api/src/Security/ApiClientAuthenticator.php

@@ -35,7 +35,7 @@ public function authenticate(Request $request): Passport
         $auth = $request->headers->get('Authorization');
         $parts = explode(':', $auth, 2);
         if (2 !== count($parts)) {
-            throw new CustomUserMessageAuthenticationException('Invalid authorization explode');
+            throw new CustomUserMessageAuthenticationException('Invalid token format');
         }
 
         $userIdentifier = $parts[0];

api/tests/Archive/ArchiveApiTest.php

@@ -34,12 +34,31 @@ public function testPostArchive(): void
         $id = $json['id'];
         $this->assertMatchesRegularExpression('#^[0-9a-fA-F]{8}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{12}$#', $id);
         $this->assertEquals($identifier, $json['identifier']);
-        $this->assertEquals('created', $json['status']);
+        $this->assertEquals('ready', $json['status']);
         $this->assertArrayHasKey('downloadUrl', $json);
         $this->assertMatchesRegularExpression(sprintf('#^http://localhost/archives/%s/download\?jwt=.+$#', $id), $json['downloadUrl']);
 
         $archive = $this->getArchiveFromDatabase($id);
         $this->expectedFiles($files, $archive);
+
+        $archivePath = $this->getArchiveDir().DIRECTORY_SEPARATOR.$id.'.zip';
+        $this->assertTrue(file_exists($archivePath));
+
+        $response = $this->request('GET', $json['downloadUrl']);
+        $html = $response->getContent();
+        if (1 !== preg_match('#document\.location = \'([^\']+)\'#', $html, $matches)) {
+            throw new \Exception('Cannot find redirect location in HTML');
+        }
+        $downloadUrl = $matches[1];
+
+        ob_start();
+        ob_start();
+        $response = $this->request('GET', $downloadUrl);
+        ob_end_clean();
+        ob_end_clean();
+        $this->assertEquals('attachment; filename="foo.zip"', $response->getHeaders()['content-disposition'][0]);
+
+        $this->removeArchive($id);
     }
 
     public function testPutArchiveReturnsMethodNotAllowed(): void

api/tests/Archive/PostArchiveApiTest.php

@@ -91,12 +91,17 @@ private function doTestPostArchiveOK(array $files, array $options = []): void
         } else {
             $this->assertNull($json['expiresAt']);
         }
-        $this->assertEquals('created', $json['status']);
+        $this->assertEquals('ready', $json['status']);
         $this->assertArrayHasKey('downloadUrl', $json);
         $this->assertMatchesRegularExpression(sprintf('#^http://localhost/archives/%s/download\?jwt=.+$#', $id), $json['downloadUrl']);
 
         $archive = $this->getArchiveFromDatabase($id);
         $this->expectedFiles($files, $archive);  
+
+        $archivePath = $this->getArchiveDir().DIRECTORY_SEPARATOR.$id.'.zip';
+        $this->assertTrue(file_exists($archivePath));
+
+        $this->removeArchive($id);
     }
 
     public function testPostArchiveWithEmptyIdentifierReturns422(): void