Skip to content

Commit 516f514

Browse files
committed
some fix
1 parent 586502a commit 516f514

File tree

13 files changed

+77
-140
lines changed

13 files changed

+77
-140
lines changed

api/config/packages/messenger.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ framework:
1212

1313
routing:
1414
# Route your messages to the transports
15-
'App\Consumer\Handler\BuildMessage': async
16-
'App\Consumer\Handler\DeleteMessage': async
17-
'App\Consumer\Handler\CleanMessage': async
15+
'App\Consumer\Handler\BuildArchive': async
16+
'App\Consumer\Handler\DeleteArchive': async
17+
'App\Consumer\Handler\CleanOldArchives': async
1818

1919
# when@test:
2020
# framework:

api/config/services.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ services:
5353

5454
GuzzleHttp\ClientInterface: '@GuzzleHttp\Client'
5555

56-
App\Api\Processor\ArchiveInputProcessor:
56+
App\Api\Processor\ArchiveProcessor:
5757
arguments:
5858
$maxExpirationTime: '%env(int:MAX_EXPIRATION_TIME)%'
5959

api/src/Api/Processor/ArchiveInputProcessor.php renamed to api/src/Api/Processor/ArchiveProcessor.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@
88
use App\Entity\Archive;
99
use ApiPlatform\Metadata\Operation;
1010
use App\Archive\IdentifierGenerator;
11-
use App\Consumer\Handler\BuildMessage;
1211
use Doctrine\ORM\EntityManagerInterface;
1312
use ApiPlatform\State\ProcessorInterface;
1413
use Symfony\Bundle\SecurityBundle\Security;
1514
use ApiPlatform\Validator\ValidatorInterface;
1615
use ApiPlatform\Serializer\AbstractItemNormalizer;
16+
use App\Consumer\Handler\BuildArchive;
1717
use Symfony\Component\Messenger\MessageBusInterface;
1818
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
1919

20-
class ArchiveInputProcessor implements ProcessorInterface
20+
class ArchiveProcessor implements ProcessorInterface
2121
{
2222
private ValidatorInterface $validator;
2323
private IdentifierGenerator $identifierGenerator;
@@ -97,7 +97,7 @@ public function process(mixed $data, Operation $operation, array $uriVariables =
9797
$this->em->persist($object);
9898
$this->em->flush();
9999

100-
$this->bus->dispatch(new BuildMessage((['id' => $object->getId()])));
100+
$this->bus->dispatch(new BuildArchive($object->getId()));
101101

102102
return $object;
103103
}

api/src/Command/CleanOldArchivesCommand.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace App\Command;
66

7-
use App\Consumer\Handler\CleanMessage;
7+
use App\Consumer\Handler\CleanOldArchives;
88
use Symfony\Component\Console\Command\Command;
99
use Symfony\Component\Console\Input\InputInterface;
1010
use Symfony\Component\Messenger\MessageBusInterface;
@@ -31,7 +31,7 @@ protected function configure()
3131

3232
protected function execute(InputInterface $input, OutputInterface $output)
3333
{
34-
$this->bus->dispatch(new CleanMessage([]));
34+
$this->bus->dispatch(new CleanOldArchives());
3535

3636
$output->writeln('Clean triggered!');
3737

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace App\Consumer\Handler;
6+
7+
class BuildArchive
8+
{
9+
public function __construct(private string $id = '')
10+
{
11+
}
12+
13+
public function getId(): string
14+
{
15+
return $this->id;
16+
}
17+
}

api/src/Consumer/Handler/BuildArchiveHandler.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
use App\Entity\Archive;
99
use Doctrine\DBAL\LockMode;
1010
use App\Archive\ArchiveManager;
11-
use App\Consumer\Handler\BuildMessage;
1211
use Doctrine\ORM\EntityManagerInterface;
1312
use Symfony\Component\Messenger\Attribute\AsMessageHandler;
1413
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
@@ -25,10 +24,9 @@ public function __construct(ArchiveManager $archiveManager, EntityManagerInterfa
2524
$this->em = $em;
2625
}
2726

28-
public function __invoke(BuildMessage $message): void
27+
public function __invoke(BuildArchive $message): void
2928
{
30-
$payload = $message->getPayload();
31-
$id = $payload['id'];
29+
$id = $message->getId();
3230

3331
$archive = $this->em->transactional(function () use ($id): ?Archive {
3432
$archive = $this->em->find(Archive::class, $id, LockMode::PESSIMISTIC_WRITE);

api/src/Consumer/Handler/BuildMessage.php

Lines changed: 0 additions & 76 deletions
This file was deleted.

api/src/Consumer/Handler/DeleteMessage.php renamed to api/src/Consumer/Handler/CleanOldArchives.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace App\Consumer\Handler;
66

7-
class DeleteMessage extends BuildMessage
7+
class CleanOldArchives extends BuildArchive
88
{
99

10-
}
10+
}

api/src/Consumer/Handler/CleanOldArchivesHandler.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
namespace App\Consumer\Handler;
66

77
use App\Entity\Archive;
8-
use App\Consumer\Handler\EventMessage;
98
use Doctrine\ORM\EntityManagerInterface;
109
use Symfony\Component\Messenger\MessageBusInterface;
1110
use Symfony\Component\Messenger\Attribute\AsMessageHandler;
@@ -19,14 +18,12 @@ public function __construct(private MessageBusInterface $bus,
1918

2019
}
2120

22-
public function __invoke(CleanMessage $message): void
21+
public function __invoke(CleanOldArchives $message): void
2322
{
2423
$archives = $this->em->getRepository(Archive::class)->getExpired();
2524

2625
foreach ($archives as $archive) {
27-
$this->bus->dispatch(new DeleteMessage([
28-
'id' => $archive->getId(),
29-
]));
26+
$this->bus->dispatch(new DeleteArchive($archive->getId()));
3027
}
3128
}
3229
}

api/src/Consumer/Handler/CleanMessage.php renamed to api/src/Consumer/Handler/DeleteArchive.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace App\Consumer\Handler;
66

7-
class CleanMessage extends BuildMessage
7+
class DeleteArchive extends BuildArchive
88
{
99

10-
}
10+
}

0 commit comments

Comments
 (0)