Skip to content

Commit

Permalink
TE-2647 Stop running pa11ycrawler (openedx#20682)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmbowman authored May 24, 2019
1 parent 4160cd1 commit a9cd9de
Show file tree
Hide file tree
Showing 13 changed files with 6 additions and 533 deletions.
160 changes: 0 additions & 160 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@
"karma-sourcemap-loader": "0.3.7",
"karma-spec-reporter": "0.0.20",
"karma-webpack": "2.0.9",
"pa11y": "4.0.1",
"pa11y-reporter-json-oldnode": "1.0.0",
"plato": "1.2.2",
"react-test-renderer": "16.4.0",
"selenium-webdriver": "3.4.0",
Expand Down
51 changes: 1 addition & 50 deletions pavelib/bok_choy.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,8 @@
from pavelib.utils.passthrough_opts import PassthroughTask
from pavelib.utils.test.bokchoy_options import (
BOKCHOY_OPTS,
PA11Y_COURSE_KEY,
PA11Y_FETCH_COURSE,
PA11Y_HTML,
PA11Y_SINGLE_URL
)
from pavelib.utils.test.suites.bokchoy_suite import BokChoyTestSuite, Pa11yCrawler
from pavelib.utils.test.suites.bokchoy_suite import BokChoyTestSuite
from pavelib.utils.test.utils import check_firefox_version
from pavelib.utils.timer import timed

Expand Down Expand Up @@ -103,39 +99,6 @@ def perf_report_bokchoy(options, passthrough_options):
run_bokchoy(options.perf_report_bokchoy, passthrough_options)


@needs('pavelib.prereqs.install_prereqs', 'get_test_course')
@cmdopts(
BOKCHOY_OPTS + [PA11Y_SINGLE_URL, PA11Y_HTML, PA11Y_COURSE_KEY, PA11Y_FETCH_COURSE],
share_with=['get_test_course', 'prepare_bokchoy_run', 'load_courses']
)
@PassthroughTask
@timed
def pa11ycrawler(options, passthrough_options):
"""
Runs pa11ycrawler against the demo-test-course to generates accessibility
reports. (See https://github.com/edx/demo-test-course)
Note: Like the bok-choy tests, this can be used with the `serversonly`
flag to get an environment running. The setup for this is the same as
for bok-choy tests, only test course is imported as well.
"""
# Modify the options object directly, so that any subsequently called tasks
# that share with this task get the modified options
options.pa11ycrawler.report_dir = Env.PA11YCRAWLER_REPORT_DIR
options.pa11ycrawler.coveragerc = options.get('coveragerc', None)
options.pa11ycrawler.should_fetch_course = getattr(
options,
'should_fetch_course',
not options.get('fasttest')
)
options.pa11ycrawler.course_key = getattr(options, 'course-key', "course-v1:edX+Test101+course")
test_suite = Pa11yCrawler('pa11ycrawler', passthrough_options=passthrough_options, **options.pa11ycrawler)
test_suite.run()

if getattr(options, 'with_html', False):
test_suite.generate_html_reports()


def run_bokchoy(options, passthrough_options):
"""
Runs BokChoyTestSuite with the given options.
Expand Down Expand Up @@ -196,15 +159,3 @@ def a11y_coverage():
Env.BOK_CHOY_A11Y_REPORT_DIR,
Env.BOK_CHOY_A11Y_COVERAGERC
)


@task
@timed
def pa11ycrawler_coverage():
"""
Generate coverage reports for bok-choy tests
"""
parse_coverage(
Env.PA11YCRAWLER_REPORT_DIR,
Env.PA11YCRAWLER_COVERAGERC
)
Loading

0 comments on commit a9cd9de

Please sign in to comment.