Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapping from errors to HTTP status codes #99

Open
lukehare opened this issue Jun 23, 2023 · 1 comment
Open

Mapping from errors to HTTP status codes #99

lukehare opened this issue Jun 23, 2023 · 1 comment

Comments

@lukehare
Copy link
Collaborator

We need to decide on the correct HTTP status codes to return in various scenarios, i.e. INTERNAL_SERVER_ERROR vs STATUS_OK in cases where the trustchain root is invalid.

See here:

trustchain/trustchain-http/src/errors.rs

Line 55 in 8e88687

impl IntoResponse for TrustchainHTTPError {

@lukehare
Copy link
Collaborator Author

Also, see

trustchain/trustchain-http/src/resolver.rs

Line 59 in f50b60c

// TODO: convert to (unknown) resolver error

@thobson88 thobson88 mentioned this issue Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukehare