Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include linting with clippy in pre-commit and actions workflows #38

Closed
3 tasks done
sgreenbury opened this issue Oct 10, 2022 · 5 comments · Fixed by #39
Closed
3 tasks done

Include linting with clippy in pre-commit and actions workflows #38

sgreenbury opened this issue Oct 10, 2022 · 5 comments · Fixed by #39
Assignees
@sgreenbury @edchapman88
Labels
good first issue Good for newcomers

Comments

@sgreenbury
Copy link
Collaborator

sgreenbury commented Oct 10, 2022 •
edited by edchapman88
Loading

Add clippy:

  • Run cargo clippy and modify code accordingly
  • pre-commit hooks
  • github actions workflows
@sgreenbury sgreenbury linked a pull request Oct 10, 2022 that will close this issue
38 clippy #39
Merged
@sgreenbury sgreenbury mentioned this issue Oct 10, 2022
Merged
@sgreenbury sgreenbury added the good first issue Good for newcomers label Jan 13, 2023
@sgreenbury
Copy link
Collaborator Author

Another one to update here are the versions for Rust edition is 2021.

@edchapman88
Copy link
Collaborator

Another one to update here are the versions for Rust edition is 2021.

This is complete.

@sgreenbury
Copy link
Collaborator Author

sgreenbury commented Feb 22, 2023 •
edited
Loading

Also dependabot. This is mainly around wasm-pack dependencies introduced early on which can now be removed.

  • Remove wasm-pack
  • Organise and clean-up Cargo.toml in trustchain-core and trustchain-ion
  • Remove any remaining use of eprintln! for error handling in a scope that returns a result

@sgreenbury
Copy link
Collaborator Author

Following recent merges to main it would make sense to revisit this and complete #39 after the above changes.

@sgreenbury
Copy link
Collaborator Author

Remaining use of eprintln! to be handled in #86.

sgreenbury added a commit that referenced this issue Apr 28, 2023
@sgreenbury
Merge pull request #39 from alan-turing-institute/38-clippy
beef6de 
Fixes for clippy and incorporation into CI (#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgreenbury sgreenbury

@edchapman88 edchapman88

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

38 clippy alan-turing-institute/trustchain
2 participants
@sgreenbury @edchapman88