Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyManager key_id bug #110

Open
edchapman88 opened this issue Aug 4, 2023 · 0 comments
Open

KeyManager key_id bug #110

edchapman88 opened this issue Aug 4, 2023 · 0 comments

Comments

@edchapman88
Copy link
Collaborator

  • IonAttestor.signing_key() takes an optional key_id argument

  • The specified key is returned by looping over the JWK's returned by the read_signing_keys() method on the AttestorKeyManager trait.

  • Currently the loop matches on the optional key_id field of the JWK struct.

  • This JWK field is currently not populated when keys are written to file by the trustchain key manager.

  • Instead, the query key_id should be matched against the compulsory id field associated with each key in the verificationMethod field of the DID Document.

  • To implement this change, the associated key id's for each key in a DID Document must be maintained in the file system (eg. written to file during the did create operation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant