New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hashing and Dhist creation #97

Open

andeElliott opened this issue Feb 12, 2018 · 0 comments

Collaborator

andeElliott commented Feb 12, 2018

@martintoreilly raised a concern about the hashing and floating point comparisons in the unordered_map, used in the construction of the dhists.

The question is what do we do about it?

We could round/bin @martintoreilly @leospinaf
We could leave it as it is and if we can justify that any floating point problems here will not change the result that much.
We could put a floating comparison after the counting step in the c++- but this could lead to annoying edge cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment