Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min and Max Offsets in Smoothed NetEMD #128

Open
andeElliott opened this issue Nov 22, 2019 · 2 comments
Open

Min and Max Offsets in Smoothed NetEMD #128

andeElliott opened this issue Nov 22, 2019 · 2 comments
Assignees

Comments

@andeElliott
Copy link
Collaborator

andeElliott commented Nov 22, 2019

The minimum and maximum offsets do not seem to depend on the smoothing width, this seems very weird.

It is currently breaking the c++ implementation, but this might be fine in the R implementation due to the R smoothing implementation. @martintoreilly can you comment?

@andeElliott
Copy link
Collaborator Author

The offset values between the two seems a little different also

@andeElliott
Copy link
Collaborator Author

okay solved the offset problem for the fast version (difference in way the smoothing is being done)

However, it is weird the way binWidth doesn't seem to be in this range.

@martintoreilly can you comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants