Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make smoothing window a flag #119

Open
martintoreilly opened this issue Oct 24, 2018 · 3 comments
Open

Make smoothing window a flag #119

martintoreilly opened this issue Oct 24, 2018 · 3 comments
Labels

Comments

@martintoreilly
Copy link
Member

Smoothing only works if the underlying x-axis is a unit "grid" and then the window must be 1.
This should be a boolean flag where the name makes it clear what it is doing and the type of data it can be applied to.

e.g. something like diffuse_to_unit_interval?

@andeElliott
Copy link
Collaborator

I presume this is for NetEMD, if so then I agree :-)

@martintoreilly
Copy link
Member Author

martintoreilly commented Feb 1, 2019

I think there are two potential robustness / generalisable approaches to smoothing.

  • Generic binning (may or may not merge discrete locations)
    • @andeElliott This should be easy with the existing C++ code
  • Convolutional smoothing (sliding window / soft binning)
    • Both @andeElliott and @leospinaf like this but we are all worried about making unnecessary extra work before publication.
      @leospinaf thinks it is important for an option / custom code to reproduce paper

@andeElliott
Copy link
Collaborator

One proposal that came up in a discussion with (@leospinaf) that is simple but gets us quite a way there.

Provide a discretisation function, that transforms the variables, prior to being send to the NetEmd comparison/optimisation with four implemented options (and let the user define others if needed)

1 Identity function (nothing is done)
2 Round to nearest integer.
3 Discretise to midpoint of user provided breaks.
4. Simple histogram binning approach, i.e. make bins with breaks at minValue+x*(maxValue-minValue)/10 for x=0,...,10

We then leave the complex stuff for later work.

What do you think?
@martintoreilly @leospinaf

@andeElliott andeElliott added this to the v1.0 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants