fix(promotion): prepare credentials for Helm chart dependency update #1977
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
==========================================
- Coverage 46.25% 46.00% -0.25%
==========================================
Files 235 235
Lines 16005 16087 +82
==========================================
- Hits 7403 7401 -2
- Misses 8242 8327 +85
+ Partials 360 359 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hidde Beydals <[email protected]>
| return nil, fmt.Errorf("error updating dependencies for chart %q: %w", chart, err) | ||
| return nil, fmt.Errorf("setting dependency versions for chart %q: %w", chart, err) | ||
| } | ||
| if err = h.prepareDependencyCredentialsFn(context.TODO(), homeDir, chartYAMLPath, namespace); err != nil { |
There was a problem hiding this comment.
Other than needing to tweak some function signatures and function calls, is there anything preventing us from getting at the right context here?
There was a problem hiding this comment.
Not really, but the size of the constructor is starting to feel outrageous and a mixed bag of not-always-so-relevant things.
Signed-off-by: Hidde Beydals <[email protected]>
Fixes: #1946