Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Improve performance of UI #1994

Merged
merged 10 commits into from May 14, 2024
Merged

chore(ui): Improve performance of UI #1994

merged 10 commits into from May 14, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented May 10, 2024

fixes #1891

  • Add "infinite loader" to Freightline
  • Add Gzip compression to UI Dev server
  • Add Gzip compression to API server
  • Lazy load appropriate components on Pipelines page
  • Several smaller enhancements

Before:
Screenshot 2024-05-10 at 10 49 02

After:
Screenshot 2024-05-10 at 10 45 23

Signed-off-by: Remington Breeze <[email protected]>
Signed-off-by: Remington Breeze <[email protected]>
Signed-off-by: Remington Breeze <[email protected]>
@rbreeze rbreeze requested a review from a team as a code owner May 10, 2024 17:51
@rbreeze rbreeze requested review from rpelczar and hiddeco May 10, 2024 17:51
Copy link

netlify bot commented May 10, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit ab178c7
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6643c6795055bd000836e11a
😎 Deploy Preview https://deploy-preview-1994.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rbreeze rbreeze changed the title UI perf chore(ui): Improve performance of UI May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 46.01%. Comparing base (0ddeb42) to head (ab178c7).

Files Patch % Lines
internal/api/server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1994      +/-   ##
==========================================
- Coverage   46.02%   46.01%   -0.01%     
==========================================
  Files         235      235              
  Lines       16101    16103       +2     
==========================================
  Hits         7410     7410              
- Misses       8330     8332       +2     
  Partials      361      361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Remington Breeze <[email protected]>
Signed-off-by: Remington Breeze <[email protected]>
go.mod Outdated Show resolved Hide resolved
Signed-off-by: Remington Breeze <[email protected]>
Signed-off-by: Remington Breeze <[email protected]>
@rbreeze rbreeze requested a review from hiddeco May 14, 2024 19:57
Signed-off-by: Remington Breeze <[email protected]>
Copy link
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @rbreeze. Took it for a test drive and it is (and feels) much faster and snappier. 🥇

@rbreeze
Copy link
Contributor Author

rbreeze commented May 14, 2024

@hiddeco Awesome! thanks for the review!

@rbreeze rbreeze added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 0509090 May 14, 2024
15 of 17 checks passed
@rbreeze rbreeze deleted the ui-perf branch May 14, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: Extreme lag with very long freightlines
2 participants