-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MakeSalt function question #25
Comments
Of course. Use random generator. |
Thanks for quick reply. I mean the license library should provide an interface to set the salt from outside. what do you think? |
"outside" where is it from? |
From my debug, I mean, currently the salt can be set to License instance directly. But when try to save license, in update method of 'LicenseManager'(line 483, 484), the salt will be force set by 'MakeSalt' method(with fixed base64 value 'AAAAAAAAA...'). So developer can only change this source code to update salt. |
Nice license library.
But I have aquestion about the salt generation.
It seems explicitSalt and implicitSalt are all generated by MakeSalt when generation a license.
In code below:
the salt based64 with empty string alwayas be 'AAAAAAAAAAAAA...', which will cause all salt be same. It will not be safe for usage. Is it necessary to customize the salt value with any interface?
The text was updated successfully, but these errors were encountered: