KAFKA-18842: add configurable max number of connectors #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-connect-connector-count-limit
branch
from
0920327 to
a138485
Compare
jjaakola-aiven
changed the title
keejon
reviewed
Feb 21, 2025
| @@ -140,6 +140,10 @@ public Response listConnectors( | |||
| public Response createConnector(final @Parameter(hidden = true) @QueryParam("forward") Boolean forward, | |||
| final @Context HttpHeaders headers, | |||
| final CreateConnectorRequest createRequest) throws Throwable { | |||
| if (!herder.validateConnectorNumberLimitNotExceeded()) { | |||
| return Response.status(Response.Status.CONFLICT).entity("Number of connectors is at maximum.").build(); | |||
There was a problem hiding this comment.
For the sake of consistency would it be better to throw ConnectRestException here?
There was a problem hiding this comment.
Good point, I'll look into this.
When Kafka Connect is offered as managed services there is need to restrict the number of allowed connectors to be run in the Connect cluster. Creating high number of connectors will make the Connect cluster unresponsive.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-connect-connector-count-limit
branch
from
a138485 to
1da9e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Kafka Connect is offered as managed services there is need to restrict the number of allowed connectors to be run in the Connect cluster. Creating high number of connectors will make the Connect cluster unresponsive.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)