Removing worker.properties loading from IcebergSinkConfig #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker properties parsing is breaking a lot of abstractions from Kafka Connect perspective and exposing to the connector the properties that should not be exposed. More over it breaks config providers support. The client configuration for the control topic should be specified in the connector configuration, and it should be connector's responsibility to provide the necessary configs.
AnatolyPopov
force-pushed
the
anatolii/removing-worker-properties-parsing
branch
from
0400648 to
1ba2e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker properties parsing is breaking a lot of abstractions from Kafka Connect perspective and exposing to the connector the properties that should not be exposed. More over it breaks config providers support.
The client configuration for the control topic should be specified in the connector configuration, and it should be connector's responsibility to provide the necessary configs.