Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airodump-ng: refactor displaying of STATIONs #2495

Closed
wants to merge 1 commit into from

Conversation

gemesa
Copy link
Contributor

@gemesa gemesa commented Mar 4, 2023

Did some refactoring in airodump-ng, this way the code can be extended easier if we want to add additional - variable length - columns. Main difference is that I replaced printf() with snprintf() so It is also consistent with the rest of the code.
This is a preparation for implementing #2167. I think that feature is a good idea and also got some attention by other users so I will reimplement it. That implementation has some bugs though, like the empty lines and does not handle the case properly if the manufacturer string is longer than 32 characters.

Fixed some indentation issues also in the displaying of stations.

Before:

$ sudo airodump-ng wlp0s20f0u1
 BSSID              STATION            PWR   Rate    Lost    Frames  Notes  Probes

 XX:XX:XX:XX:XX:XX  XX:XX:XX:XX:XX:XX  -55    0 - 6      0        1

As you can see Rate and Lost column titles are shifted by one space.

After:

$ sudo ./airodump-ng wlp0s20f0u1
 BSSID              STATION            PWR    Rate    Lost   Frames  Notes  Probes

 (not associated)   XX:XX:XX:XX:XX:XX  -87    0 - 1     18        6         XXXXXXXXXX

@gemesa
Copy link
Contributor Author

gemesa commented Mar 4, 2023

Closing for now as I have to make sure the UI keeps working properly. Will review it later.

@gemesa gemesa closed this Mar 4, 2023
@gemesa gemesa deleted the airodump-station branch March 5, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant