Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting CIs #2501

Open
Mister-X- opened this issue Mar 6, 2023 · 4 comments
Open

Add linting CIs #2501

Mister-X- opened this issue Mar 6, 2023 · 4 comments

Comments

@Mister-X-
Copy link
Collaborator

Description

Add shellcheck, pylint, and other linters to ensure things that aren't compiled are correct.

While we never hit the issue, one shell script had a typo in return being written as retun.
@gemesa
Copy link
Contributor

gemesa commented Mar 6, 2023

shellcheck is next on my todo list.

@Mister-X-
Copy link
Collaborator Author

Awesome :)

@gemesa
Copy link
Contributor

gemesa commented Mar 13, 2023

check out shfmt

@ZeroChaos-
Copy link
Collaborator

Just so it's known, I have drastically reduced the number of shellcheck issues, however, a few small ones do remain. I'll see about cleaning that up

@Mister-X- Mister-X- mentioned this issue Mar 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ZeroChaos- @Mister-X- @gemesa