Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination S3 Data Lake: Extract generic iceberg stuff to toolkit #53700

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Destination S3 Data Lake: Extract generic iceberg stuff to toolkit #53700

merged 8 commits into from
Feb 14, 2025

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Feb 14, 2025 •
edited
Loading

stacked off of #53697

each commit should be pretty self-explanatory. Changes are very mechanical, feel free to just skim.

things I'm NOT doing in this PR:

  • any nontrivial refactoring - there's some stuff that would require more effort to disentangle:
    • figure out a plan for S3DataLake.buildXYZProperties - half of these (rest, nessie) should be in the toolkit
    • some stuff in e.g. the writer, streamloader, etc - probably also belongs in toolkit

@edgao edgao requested a review from frifriSF59 February 14, 2025 20:48
@edgao edgao requested a review from a team as a code owner February 14, 2025 20:48
@vercel Vercel
Copy link

vercel bot commented Feb 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 8:49pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/s3-data-lake labels Feb 14, 2025
@edgao edgao mentioned this pull request Feb 14, 2025
Draft
frifriSF59
frifriSF59 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@frifriSF59 frifriSF59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ngl. This feels a lot cleaner

@edgao
Copy link
Contributor Author

edgao commented Feb 14, 2025

merging this into #53697 and will release them together

@edgao edgao merged commit c2a9d05 into edgao/extract_create_namespace Feb 14, 2025
29 of 31 checks passed
@edgao edgao deleted the edgao/extract_iceberg_stuff branch February 14, 2025 21:59
@edgao edgao mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frifriSF59 frifriSF59 frifriSF59 approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/s3-data-lake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @frifriSF59 @octavia-squidington-iii