fix: add F flag to remove unused imports
#52649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/format-fix
|
|
Running formatters to see what the diff would be :) |
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
connectors/source/slack
connectors/source/mysql
connectors/source/okta
connectors/source/paypal-transaction
connectors/source/pinterest
connectors/source/recharge
connectors/source/s3
connectors/source/salesforce
connectors/source/tiktok-marketing
connectors/source/typeform
connectors/source/zendesk-chat
connectors/source/zendesk-support
connectors/source/amazon-sqs
connectors/source/google-analytics-data-api
connectors/source/my-hours
connectors/source/gong
connectors/source/braze
connectors/source/railz
connectors/source/instatus
connectors/source/xero
connectors/source/convex
connectors/source/rss
connectors/source/gcs
connectors/source/google-drive
connectors/source/microsoft-sharepoint
labels
|
I personally think this is a good idea, so if CI is green-adjacent, we should prob merge this. |
…-fix-unused-imports # Conflicts: # airbyte-ci/connectors/connector_ops/connector_ops/required_reviewer_checks.py # airbyte-integrations/connectors/source-google-sheets/unit_tests/integration/custom_http_mocker.py
|
hey @natikgadzhi ,
Ci will never be green, since it is expected to bump version whenever any change in code occurs. My proposal is to merge with the ca7ac53 only and gradually fix the connectors/ci packages when we really work on them, wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add
Fflag to remove unused importsHow
add
Fflag to remove unused importsReview guide
User Impact
Can this PR be safely reverted and rolled back?