[Destination MSSQL] rc7: revert deletion logic change (#53644)

airbytehq · Feb 11, 2025 · a1f8d22 · a1f8d22
1 parent 35bc80a
commit a1f8d22
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/airbyte-integrations/connectors/destination-mssql-v2/metadata.yaml b/airbyte-integrations/connectors/destination-mssql-v2/metadata.yaml
@@ -16,7 +16,7 @@ data:
             type: GSM
   connectorType: destination
   definitionId: 37a928c1-2d5c-431a-a97d-ae236bd1ea0c
-  dockerImageTag: 0.1.8
+  dockerImageTag: 0.1.9
   dockerRepository: airbyte/destination-mssql-v2
   documentationUrl: https://docs.airbyte.com/integrations/destinations/mssql-v2
   githubIssueLabel: destination-mssql-v2

diff --git a/...ssql-v2/src/main/kotlin/io/airbyte/integrations/destination/mssql/v2/MSSQLQueryBuilder.kt b/...ssql-v2/src/main/kotlin/io/airbyte/integrations/destination/mssql/v2/MSSQLQueryBuilder.kt
@@ -157,22 +157,16 @@ const val ALTER_TABLE_MODIFY =
 
 const val DELETE_WHERE_COL_IS_NOT_NULL =
     """
-        deleteLoop:
-        DELETE TOP(5000) FROM [?].[?] WITH (TABLOCK)
+        SET NOCOUNT ON;
+        DELETE FROM [?].[?] WITH (TABLOCK)
         WHERE [?] is not NULL
-
-        IF @@ROWCOUNT > 0
-            GOTO deleteLoop
     """
 
 const val DELETE_WHERE_COL_LESS_THAN =
     """
-        deleteLoop:
-        DELETE TOP(5000) FROM [?].[?] WITH (TABLOCK)
+        SET NOCOUNT ON;
+        DELETE FROM [?].[?] WITH (TABLOCK)
         WHERE [?] < ?
-
-        IF @@ROWCOUNT > 0
-            GOTO deleteLoop
     """
 
 const val SELECT_FROM = """

diff --git a/docs/integrations/destinations/mssql-v2.md b/docs/integrations/destinations/mssql-v2.md
@@ -13,6 +13,7 @@ This connector is in early access, and SHOULD NOT be used for production workloa
 
 | Version | Date       | Pull Request                                               | Subject                                              |
 |:--------|:-----------|:-----------------------------------------------------------|:-----------------------------------------------------|
+| 0.1.9   | 2025-02-11 | [53364](https://github.com/airbytehq/airbyte/pull/53364)   | RC7: Revert deletion change.                         |
 | 0.1.8   | 2025-02-11 | [53364](https://github.com/airbytehq/airbyte/pull/53364)   | RC6: Break up deletes into loop to reduce locking.   |
 | 0.1.7   | 2025-02-07 | [53236](https://github.com/airbytehq/airbyte/pull/53236)   | RC5: Use rowlock hint.                               |
 | 0.1.6   | 2025-02-06 | [53192](https://github.com/airbytehq/airbyte/pull/53192)   | RC4: Fix config, timehandling and performance tweak. |