Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Raw Files parser option for File CDK (do not merge) #427

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Add "Raw Files" Parser option to File CDK

This PR adds a new "Raw Files" Parser option to connectors based on the File CDK, which:

  1. Doesn't parse file input
  2. Works solely with the "Copy Raw Files" option
  3. Only requires a path (glob) to files
  4. Fails "check" if not combined with the "Copy Raw Files" option

Link to Devin run: https://app.devin.ai/sessions/5a9c85a35f0d4c5aa37744cc0b08920f
Requested by: Aaron

Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - In connectors based on the File CDK, add a "Raw Files" Parser option which doesn't try to parse the file input. Instead it will be used solely with the "Copy Raw Files" option. This parser only needs the path (glob) to files; it doesn't need any file format inputs. In the same PR, we'd like to fail "check" if our new "Raw Files" parser option is not combined with the "Copy Raw Files" option. For now, we can continue to allow other parser options to be used in combination - even though at runtime, those parsing options will be ingnored if "Copy Raw Files" is selected.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the enhancement New feature or request label Mar 15, 2025
… Raw Files delivery method

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Comment on lines +42 to +43
from airbyte_cdk.sources.file_based.config.abstract_file_based_spec import AbstractFileBasedSpec
from airbyte_cdk.sources.file_based.config.validate_config_transfer_modes import use_file_transfer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move these to the top of the file.

@aaronsteers aaronsteers marked this pull request as draft March 15, 2025 20:43
@aaronsteers aaronsteers changed the title feat: add Raw Files parser option for File CDK feat: add Raw Files parser option for File CDK (do not merge) Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant