-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datetime): Migrate standard datetime parsing to whenever library #394
Conversation
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
🤖 Devin AI EngineerOriginal prompt from Aaron:
I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
def test_whenever_parser_for_iso_formats(monkeypatch): | ||
"""Test that the whenever parser is used for certain formats even when dateutil is unavailable.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameterized test seems to cover these cases. Can we delete this test?
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Closing due to inactivity for more than 7 days. |
This PR adds unit tests to verify that the datetime helper module correctly uses the 'whenever' parser for ISO/RFC compliant datetime values and falls back to dateutil.parser.parse for other formats.
Link to Devin run: https://app.devin.ai/sessions/2e37cc1080054be58292cfb5cf0551ff
Requested by: Aaron