Skip to content

Why ConsumerRebalanceListener is not expose when create a Consumer? #842

Open
@marcosschroh

Description

@marcosschroh

Hi,

Thanks for the work that you are doing!!

According to the code, the only way to use the ConsumerRebalanceListener is using the subscribe method, I was wondering: Why is not also possible to set a ConsumerRebalanceListener when a Consumer is created using the __init__? I think if we do this, the testing will become easier because of mocking and you won’t be force to use the subscribe method.

In the init method is used
self._subscription.subscribe(…) which accepts a ConsumerRebalanceListener argument, so I think it is possible to make it.

Ideally, I think both options should be possible. If the user set a new ConsumerRebalanceListenter using the subscribe method, it should prevail.

what do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions