Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Audio sound does not stop playing #13

Open
RickyYCheng opened this issue Mar 23, 2023 · 2 comments
Open

[BUG] Audio sound does not stop playing #13

RickyYCheng opened this issue Mar 23, 2023 · 2 comments

Comments

@RickyYCheng
Copy link
Contributor

If you click extremly fast when the sentences play not to the end as well as the new sentence comes up, there will be two sentences play together.

@aiman-al-masoud
Copy link
Owner

Thanks for the report! Yes, this is a known old issue, it is due to this utility function which the app is currently calling everywhere to play sounds. I think this can be fixed by adding a method "playSound()" to the Context facade with an implementation that includes a sort of "audio-lock" so that no two sounds can play at the same time.

Also, sorry for the overall quality of the code, the process of migrating to from JS to Typescript is still ongoing (but mostly done), so things are looking a little bit shabby and precarious.

@RickyYCheng
Copy link
Contributor Author

RickyYCheng commented Mar 24, 2023

Also, sorry for the overall quality of the code, the process of migrating to from JS to Typescript is still ongoing (but mostly done), so things are looking a little bit shabby and precarious.

Never to mention that, you're doing great job.
I never learn React and TS / JS before, so it could be little bit harder to read the source. I want to know the strcuture of the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants