Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: BrokenHttpLinksCheckerSpec is broken #294

Open
rdmueller opened this issue Jan 14, 2022 · 1 comment
Open

Tests: BrokenHttpLinksCheckerSpec is broken #294

rdmueller opened this issue Jan 14, 2022 · 1 comment

Comments

@rdmueller
Copy link
Collaborator

Condition not satisfied:

collector.getFindings().size() == 1
|         |             |      |
|         []            0      false
Checking results for External Links Check
 1 anchor href attribute checked,
 0 finding(s)
[]

	at org.aim42.htmlsanitycheck.check.BrokenHttpLinksCheckerSpec.redirects are recognized and their new location is contained in warning message(BrokenHttpLinksCheckerSpec.groovy:218)

https://github.com/aim42/htmlSanityCheck/blob/master/src/test/groovy/org/aim42/htmlsanitycheck/check/BrokenHttpLinksCheckerSpec.groovy#L205

I guess the old arc42 site has changed so that this test is broken.

@ascheman
Copy link
Member

ascheman commented Jan 4, 2023

Didn't see this issue but ran into the very same problem - and tried to resolve it with 5fe38a1.
Please close the issue, if you consider this a proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants