You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hence, it would probably be good to move to parsing this from the XML, as this is more robust, especially when we have to support both SIRIUS-enabled and regular QE.
Also a step towards #353. Note that this issue is rather general, and cannot be closed anytime soon since some important output (e.g. the atomic magnetic moments) is not yet in the XML. Perhaps we can make this issue a place where we keep track of things that we would like to see parsed from the XML, and then check if it's there, and if not open an issue on the QE repo.
The text was updated successfully, but these errors were encountered:
# TODO: should we parse 'steps' too? Are they already added in the output trajectory?
Basically, I'll try to add all information in the steps output in the XML to the output_trajectory node. This will require merging it with the output_trajectory parsed from the stdout.
Alright, digging through the parser code some more, I finally saw that the final structure is parsed from the XML. Bumping down the priority a bit then, since I only really needed that one for the SIRIUS direct minimization runs. ^^
I've noticed that in more recent versions of Quantum ESPRESSO (have to check from which version exactly), the structure is also in the XML output:
Hence, it would probably be good to move to parsing this from the XML, as this is more robust, especially when we have to support both SIRIUS-enabled and regular QE.
Also a step towards #353. Note that this issue is rather general, and cannot be closed anytime soon since some important output (e.g. the atomic magnetic moments) is not yet in the XML. Perhaps we can make this issue a place where we keep track of things that we would like to see parsed from the XML, and then check if it's there, and if not open an issue on the QE repo.
The text was updated successfully, but these errors were encountered: